Re: [PATCH] Change "checkpoint starting" message to use "wal"

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Change "checkpoint starting" message to use "wal"
Date: 2018-11-29 09:09:52
Message-ID: 20181129090952.GH9004@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 29, 2018 at 10:04:12AM +0100, Christoph Berg wrote:
> There's hundreds of other internal uses of xlog that were not touched
> either, only the user-facing parts were changed.

I have heard of them ;)
Just wondering if this one is worth renaming as the variable is
isolated. It is not a big deal to do nothing though.

> If this gets accepted, I'll submit a patch for pgbadger so it can be
> updated before PG12 hits the field.

Your change looks acceptable to me FWIW.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message legrand legrand 2018-11-29 09:23:28 Re: [PROPOSAL] extend the object names to the qualified names in pg_stat_statements
Previous Message Michael Paquier 2018-11-29 09:04:17 Re: Add pg_partition_tree to doc index