Re: [PATCH] Change "checkpoint starting" message to use "wal"

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Change "checkpoint starting" message to use "wal"
Date: 2018-11-29 21:56:44
Message-ID: 20181129215644.f6kzxzj4x52pb3vq@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2018-Nov-29, Robert Haas wrote:

> On Thu, Nov 29, 2018 at 4:10 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > On Thu, Nov 29, 2018 at 10:04:12AM +0100, Christoph Berg wrote:
> > > There's hundreds of other internal uses of xlog that were not touched
> > > either, only the user-facing parts were changed.
> >
> > I have heard of them ;)
> > Just wondering if this one is worth renaming as the variable is
> > isolated. It is not a big deal to do nothing though.
> Well, if we rename the user-visible part but not the internal part,
> then they don't match, which is odd.

But we already did that when we renamed all the xlog to WAL terminology
... why do we care about it now particularly?

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2018-11-29 22:16:36 Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT
Previous Message Alvaro Herrera 2018-11-29 21:48:50 Re: New GUC to sample log queries