| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: condition variables |
| Date: | 2016-09-06 11:59:06 |
| Message-ID: | CA+TgmoZn2Sg_p8Zc6CoN+Wsi8ZoMAYOkzx=E62T5whVg6Qifgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 5, 2016 at 3:17 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Mon, Aug 15, 2016 at 10:35 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>>> Don't you need to set proc->cvSleeping = false in ConditionVariableSignal?
>>>
>>> I poked at this a bit... OK, a lot... and have some feedback:
>>>
>>> 1. As above, we need to clear cvSleeping before setting the latch.
>>
>> Right, OK.
>>
>
> I have independently faced this problem while using your patch and for
> now I have updated my local copy. If possible, please send an updated
> patch as this patch could be used for development of various
> parallelism projects.
Thomas already posted an updated patch in the same message where he
reported the problem.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-09-06 12:02:25 | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| Previous Message | David Steele | 2016-09-06 11:52:45 | Re: Proposal for changes to recovery.conf API |