| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: condition variables |
| Date: | 2016-09-05 09:47:18 |
| Message-ID: | CAA4eK1Lvgi=-Nx0xB=nUN6DB8EMi0zpMweHWkJiAFVfcGmYGaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 15, 2016 at 10:35 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> Don't you need to set proc->cvSleeping = false in ConditionVariableSignal?
>>
>> I poked at this a bit... OK, a lot... and have some feedback:
>>
>> 1. As above, we need to clear cvSleeping before setting the latch.
>
> Right, OK.
>
I have independently faced this problem while using your patch and for
now I have updated my local copy. If possible, please send an updated
patch as this patch could be used for development of various
parallelism projects.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2016-09-05 09:55:36 | Re: Assert(LWLockHeldByMeInMode(lock, LW_EXCLUSIVE)) |
| Previous Message | Simon Riggs | 2016-09-05 09:42:52 | Re: Assert(LWLockHeldByMeInMode(lock, LW_EXCLUSIVE)) |