| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | 自己 <zoulx1982(at)163(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Re: BUG #15039: some question about hash index code |
| Date: | 2018-02-01 20:33:49 |
| Message-ID: | CA+TgmoZHLOP_b+b+E_bWhBP1YsCe7oTDPzfMyTNoOPE7cH_+2g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Thu, Feb 1, 2018 at 1:51 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Attached patch fix_markbufdirty_hash_index_v1.patch fixes the problem
> by calling MarkBufferDirty at the appropriate place in the code.
> However, I noticed that we might end up calling MarkBufferDirty twice
> for metapage in _hash_addovflpage. I think we can easily avoid that
> as is done in patch fix_markbufdirty_hash_index_v1.1.patch.
IIUC, the v1 patch is fixing a bug, but the v1.1 patch is a minor
optimization. I'm going to take the easy way out and push v1 to v10
and master.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Kohn | 2018-02-01 22:54:22 | Re: BUG #15036: Un-killable queries Hanging in BgWorkerShutdown |
| Previous Message | Peter Eisentraut | 2018-02-01 15:24:48 | Re: BUG #14952: COPY fails to fill in IDENTITY column default value |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-02-01 22:13:06 | Re: Cancelling parallel query leads to segfault |
| Previous Message | Vladimir Sitnikov | 2018-02-01 20:28:33 | Re: Built-in connection pooling |