Re: Re: BUG #15039: some question about hash index code

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: 自己 <zoulx1982(at)163(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Re: BUG #15039: some question about hash index code
Date: 2018-02-02 02:46:52
Message-ID: CAA4eK1L=8=OiCEoj1k6Wq84-WT6t_DJ=fK=vFuV0yMRq0AEOeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Feb 2, 2018 at 2:03 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Feb 1, 2018 at 1:51 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> Attached patch fix_markbufdirty_hash_index_v1.patch fixes the problem
>> by calling MarkBufferDirty at the appropriate place in the code.
>> However, I noticed that we might end up calling MarkBufferDirty twice
>> for metapage in _hash_addovflpage. I think we can easily avoid that
>> as is done in patch fix_markbufdirty_hash_index_v1.1.patch.
>
> IIUC, the v1 patch is fixing a bug, but the v1.1 patch is a minor
> optimization.
>

Yes.

> I'm going to take the easy way out and push v1 to v10
> and master.
>

Okay.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Srikanth M K 2018-02-02 05:09:30 Difference in behaviour between 9.6 and 10.1: GROUPING with ROLLUP , difference in order and error with unnest
Previous Message Michael Paquier 2018-02-02 01:49:39 Re: BUG #14952: COPY fails to fill in IDENTITY column default value

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2018-02-02 02:47:27 [bug fix] ECPG: freeing memory for pgtypes crashes on Windows
Previous Message Michael Paquier 2018-02-02 02:25:32 Re: [HACKERS] generated columns