| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | steven(dot)winfield(at)cantabcapital(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14952: COPY fails to fill in IDENTITY column default value |
| Date: | 2018-02-01 15:24:48 |
| Message-ID: | 6a328b03-6912-2d12-2be6-387d4a1613c7@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 12/30/17 18:26, Michael Paquier wrote:
> A RangeVar is used for the proposed patch 0002. Still does it matter? In
> the scenario proposed here, which is to fix ALTER TABLE ADD COLUMN
> GENERATED, then the sequence gets created and visible only once the
> transaction adding the column has been created.
>
> char identity; /* attidentity setting */
> + RangeVar *identitySequence;
> CollateClause *collClause; /* untransformed COLLATE spec, if any */
> It mat be better to tell that this is used to create a sequence in the
> same transaction as the one doing the parsing.
I would like to get this into next week's minor release as a bug fix.
Other than tweaking some of the comments, is there any more feedback on
this?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-02-01 20:33:49 | Re: Re: BUG #15039: some question about hash index code |
| Previous Message | PG Bug reporting form | 2018-02-01 10:48:55 | BUG #15043: postgresql yum repository dependency problem |