| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Avoid valgrind complaint about write() of uninitalized bytes. |
| Date: | 2018-02-22 14:32:32 |
| Message-ID: | CA+TgmoZ7AKrzOVO7L3opSGyEEj07e9YU+20O=58UsmXjYWTZ9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Feb 21, 2018 at 3:18 PM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Wed, Feb 21, 2018 at 10:55 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>> Sure, but it looks like it has the exact same underlying cause to the
>> LogicalTapeFreeze() issue. It shouldn't be very hard to write an
>> equivalent patch for LogicalTapeRewindForRead() -- I pointed out that
>> this could happen there instead before the first patch went in, in
>> fact. My mistake was to imagine that that could never happen during
>> the regression tests.
>
> Attached patch does this. I cannot recreate this issue locally, but
> this should still fix it on skink.
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-02-22 15:05:47 | pgsql: postgres_fdw: Fix interaction of PHVs with child joins. |
| Previous Message | Robert Haas | 2018-02-22 13:55:43 | Re: pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-02-22 15:06:42 | Re: PlaceHolderVars in pushed down child-join cause error |
| Previous Message | Robert Haas | 2018-02-22 14:25:59 | Re: [doc fix] Correct calculation of vm.nr_hugepages |