From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Avoid valgrind complaint about write() of uninitalized bytes. |
Date: | 2018-02-21 20:18:01 |
Message-ID: | CAH2-WzkUjvzhr+vSoQWWsURk2c7O4tzcwLzVOk1rBJ_RWt-4cg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Feb 21, 2018 at 10:55 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> Sure, but it looks like it has the exact same underlying cause to the
> LogicalTapeFreeze() issue. It shouldn't be very hard to write an
> equivalent patch for LogicalTapeRewindForRead() -- I pointed out that
> this could happen there instead before the first patch went in, in
> fact. My mistake was to imagine that that could never happen during
> the regression tests.
Attached patch does this. I cannot recreate this issue locally, but
this should still fix it on skink.
> Should we even be doing a parallel external sort here? It's hardly
> part of an intentional effort to test the code. I had to push to get
> us to give external sorts test coverage at one point about 18 months
> ago, because of concerns about the overhead/duration of external
> sorts. Not that I feel strongly about this myself.
I suppose that we should commit this patch, even if we subsequently
suppress parallel CREATE INDEX in the multiple-row-versions isolation
test.
--
Peter Geoghegan
Attachment | Content-Type | Size |
---|---|---|
0001-Avoid-another-Valgrind-complaint-about-a-logtape.c-w.patch | text/x-patch | 2.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2018-02-21 22:56:18 | Re: pgsql: Allow UNIQUE indexes on partitioned tables |
Previous Message | Peter Geoghegan | 2018-02-21 18:55:20 | Re: pgsql: Avoid valgrind complaint about write() of uninitalized bytes. |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2018-02-21 20:28:49 | Re: [doc fix] Correct calculation of vm.nr_hugepages |
Previous Message | Robert Haas | 2018-02-21 20:14:57 | Re: [doc fix] Correct calculation of vm.nr_hugepages |