Re: pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.
Date: 2018-02-22 13:55:43
Message-ID: CA+Tgmoan7YnZD9oLmBtAGs5+E9G35xf8c1r=bbY+dtmztLKQww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Feb 22, 2018 at 8:31 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Feb 22, 2018 at 12:35 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>>> Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.
>>
>> This seems to have produced some plan instability in the buildfarm.
>
> I was worried about that. Looking at it now. I wish we had some way
> to figure out whether a given plan was likely to be unstable on the
> buildfarm other than committing it and seeing what happens. It's
> surprisingly difficult to write non-trivial tests that produce
> consistent EXPLAIN output, and annoyingly time-consuming to try to
> figure out why they don't.

I pushed a commit to try to fix this by making the three tables being
joined not all identical in terms of row count. That seems like a
clear improvement, but there's every possibility it won't solve the
problem entirely. I'll keep an eye on the buildfarm and see what
happens.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2018-02-22 14:32:32 pgsql: Avoid another valgrind complaint about write() of uninitalized b
Previous Message Robert Haas 2018-02-22 13:54:35 pgsql: Try to stabilize EXPLAIN output in partition_check test.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-02-22 14:25:28 Re: Possible performance regression in version 10.1 with pgbench read-write tests.
Previous Message Peter Eisentraut 2018-02-22 13:34:30 check error messages in SSL tests