| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Emre Hasegeli <emre(at)hasegeli(dot)com>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2017-09-15 15:25:30 |
| Message-ID: | CA+TgmoYgg8=m9+Y54Az1r+KBpMuiEOZM_DLDF04jMP4twGR3Ng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 15, 2017 at 4:23 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> /* don't merge the following same functions with different types
> into single macros so that double evaluation won't happen */
>
> Is it still too verbose?
Personally, I don't think such a comment has much value, but I am not
going to spend a lot of time arguing about it. It's really up to the
eventual committer to decide, and that probably won't be me in this
case. My knowledge of the geometric types isn't great, and I am a tad
busy breaking^Wimproving things I do understand.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2017-09-15 15:34:09 | Re: Surjective functional indexes |
| Previous Message | Robert Haas | 2017-09-15 15:19:19 | Re: postgres_fdw: evaluate placeholdervars on remote server |