Re: [PATCH] Improve geometric types

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: robertmhaas(at)gmail(dot)com
Cc: emre(at)hasegeli(dot)com, a(dot)alekseev(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Improve geometric types
Date: 2017-09-19 06:08:43
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

At Fri, 15 Sep 2017 11:25:30 -0400, Robert Haas <robertmhaas(at)gmail(dot)com> wrote in <CA+TgmoYgg8=m9+Y54Az1r+KBpMuiEOZM_DLDF04jMP4twGR3Ng(at)mail(dot)gmail(dot)com>
> On Fri, Sep 15, 2017 at 4:23 AM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > /* don't merge the following same functions with different types
> > into single macros so that double evaluation won't happen */
> >
> > Is it still too verbose?
> Personally, I don't think such a comment has much value, but I am not
> going to spend a lot of time arguing about it. It's really up to the
> eventual committer to decide, and that probably won't be me in this
> case. My knowledge of the geometric types isn't great, and I am a tad
> busy breaking^Wimproving things I do understand.

Ok, I agree with you.

# Though it is not a issue of geometric types :p

I'll withdrow the comment. Maybe someone notices of that when
reviewing such a patch.


Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2017-09-19 06:25:43 Re: Back-branch release notes up for review
Previous Message Kyotaro HORIGUCHI 2017-09-19 06:04:30 Re: Race between SELECT and ALTER TABLE NO INHERIT