| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: planstate_tree_walker |
| Date: | 2015-09-17 13:37:04 |
| Message-ID: | CA+TgmoYcwEM6RstquXbKfGJ9F3DbfRFRnRZMDPHkHV-nqr_7fA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 17, 2015 at 9:33 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Here is a patch that *just* introduces planstate_tree_walker and which
>> is hopefully correct. I stole the logic from ExplainPreScanNode,
>> which I also refactored to use the new walker instead of duplicating
>> the logic.
>
> It seems a little odd to have removed functions from explain.c altogether
> but left their header comments behind. Otherwise this seems sound.
D'oh!
OK, will fix that before committing. Thanks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-09-17 13:42:12 | Re: honour TEMP_CONFIG in pg_upgrade tests |
| Previous Message | Andrew Dunstan | 2015-09-17 13:35:04 | honour TEMP_CONFIG in pg_upgrade tests |