Re: pgsql: Notify bgworker registrant after freeing worker slot.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Notify bgworker registrant after freeing worker slot.
Date: 2017-03-06 17:23:40
Message-ID: CA+TgmoYWXm0BPxMcFa4c8rhR0eGOp_wJgXuxxFew1c823ycp-g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Mar 6, 2017 at 8:21 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Mar 3, 2017 at 9:27 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>> Notify bgworker registrant after freeing worker slot.
>
> After this commit, I am seeing parallel queires being stucked on my
> windows machine. I think the notify pid is stale in
> ReportBackgroundWorkerExit() as we are freeing the same in
> ForgetBackgroundWorker(). Attached patch fixes the problem for me.
>
> Ashutosh Sharma has independently reported (offlist) this problem to me.

Thanks for the report and patch. Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-03-06 17:48:38 pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.
Previous Message Robert Haas 2017-03-06 17:23:38 pgsql: Fix user-after-free bug.