From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Notify bgworker registrant after freeing worker slot. |
Date: | 2017-03-06 18:44:36 |
Message-ID: | 21855.1488825876@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Mar 6, 2017 at 8:21 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> On Fri, Mar 3, 2017 at 9:27 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>>> Notify bgworker registrant after freeing worker slot.
>> After this commit, I am seeing parallel queires being stucked on my
>> windows machine. I think the notify pid is stale in
>> ReportBackgroundWorkerExit() as we are freeing the same in
>> ForgetBackgroundWorker(). Attached patch fixes the problem for me.
>> Ashutosh Sharma has independently reported (offlist) this problem to me.
> Thanks for the report and patch. Committed.
Hmm, maybe this also explains skink's recent failure in the
select_parallel test. I was going to go try to duplicate that, but
now maybe I'll just wait to see if its next run is green.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2017-03-06 19:41:58 | Re: pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted. |
Previous Message | Peter Eisentraut | 2017-03-06 18:34:49 | pgsql: Use class_args field in opclass_drop |