Re: PageGetFreeSpace() isn't quite the right thing for some of its callers

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: PageGetFreeSpace() isn't quite the right thing for some of its callers
Date: 2019-04-09 20:46:24
Message-ID: CAH2-Wzn82-H5Xbe5P898rLp6Y_6=wrjxEfBXwP133j32aVuvUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 9, 2019 at 11:35 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Maybe we should rename it.

There are only about 20 PageGetFreeSpace() callers, so that shouldn't
be too disruptive. We might also need to rename
PageGetFreeSpaceForMultipleTuples() and PageGetExactFreeSpace(). And,
heapam.c won't be able to call whatever we rename PageGetFreeSpace()
to.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashwin Agrawal 2019-04-09 21:03:09 Re: Zedstore - compressed in-core columnar storage
Previous Message Alvaro Herrera 2019-04-09 20:35:07 Re: pg_dump is broken for partition tablespaces