Re: [PATCH] pg_convert improvement

From: Yurii Rashkovskii <yrashk(at)gmail(dot)com>
To: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pg_convert improvement
Date: 2023-11-28 01:16:17
Message-ID: CA+RLCQwdyLK49TyiAZnYXvO5xGzZ9jEUpg6FX62E3LeaN5jJZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Bertrand,

> Did some minor changes in the attached:
>
> - Started the multi-line comment with an upper case and finished
> it with a "." and re-worded a bit.
> - Ran pgindent
>
> What do you think about the attached?
>

It looks great!

>
> Also, might be good to create a CF entry [1] so that the patch proposal
> does not get lost
> and gets visibility.
>

Just submitted it to SF. Thank you for the review!

--
Y.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2023-11-28 01:17:32 BackgroundPsql's set_query_timer_restart() may not work
Previous Message Tom Lane 2023-11-28 01:14:56 Re: SSL tests fail on OpenSSL v3.2.0