Re: [PATCH] pg_convert improvement

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Yurii Rashkovskii <yrashk(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pg_convert improvement
Date: 2023-11-28 06:45:28
Message-ID: 7016812c-bb9c-4e57-957f-51d71535ce82@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 11/28/23 2:16 AM, Yurii Rashkovskii wrote:
>  Hi Bertrand,
>
>
> Did some minor changes in the attached:
>
> - Started the multi-line comment with an upper case and finished
> it with a "." and re-worded a bit.
> - Ran pgindent
>
> What do you think about the attached?
>
>
> It looks great!
>
>
> Also, might be good to create a CF entry [1] so that the patch proposal does not get lost
> and gets visibility.
>
>
> Just submitted it to SF. Thank you for the review!
>

Thanks! Just marked it as "Ready for Committer".

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2023-11-28 06:49:48 Re: Synchronizing slots from primary to standby
Previous Message Bharath Rupireddy 2023-11-28 06:28:27 Re: BackgroundPsql's set_query_timer_restart() may not work