| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Tristan Partin" <tristan(at)neon(dot)tech> |
| Cc: | "Michael Paquier" <michael(at)paquier(dot)xyz>, "Nazir Bilal Yavuz" <byavuz81(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>, "Bo Anderson" <mail(at)boanderson(dot)me>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SSL tests fail on OpenSSL v3.2.0 |
| Date: | 2023-11-28 01:14:56 |
| Message-ID: | 4046690.1701134096@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Tristan Partin" <tristan(at)neon(dot)tech> writes:
> On Mon Nov 27, 2023 at 6:21 PM CST, Tom Lane wrote:
>> What about LibreSSL? In general, I'm not too pleased with just assuming
>> that BIO_get_app_data exists.
> Falling back to what existed before is invalid.
Well, sure it only worked by accident, but it did work with older
OpenSSL versions. If we assume that BIO_get_app_data exists, and
somebody tries to use it with a version that hasn't got that,
it won't work.
Having said that, my concern was mainly driven by the comments in
configure.ac claiming that this was an OpenSSL 1.1.0 addition.
Looking at the relevant commits, 593d4e47d and 5c6df67e0, it seems
that that was less about "the function doesn't exist before 1.1.0"
and more about "in 1.1.0 we have to use the function because we
can no longer directly access the ptr field". If the function
does exist in 0.9.8 then I concur that we don't need to test.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yurii Rashkovskii | 2023-11-28 01:16:17 | Re: [PATCH] pg_convert improvement |
| Previous Message | Peter Geoghegan | 2023-11-28 01:07:46 | Re: POC, WIP: OR-clause support for indexes |