| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Estimating HugePages Requirements? |
| Date: | 2021-09-08 17:52:33 |
| Message-ID: | C35CB94F-D391-4E52-AB08-A726112FA852@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers |
On 9/8/21, 12:11 AM, "Fujii Masao" <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> Thanks for adding useful feature!
:)
> + {"shared_memory_size", PGC_INTERNAL, RESOURCES_MEM,
>
> When reading the applied code, I found the category of shared_memory_size
> is RESOURCES_MEM. Why? This seems right because the parameter is related
> to memory resource. But since its context is PGC_INTERNAL, PRESET_OPTIONS
> is more proper as the category? BTW, the category of any other
> PGC_INTERNAL parameters seems to be PRESET_OPTIONS.
Yeah, I did wonder about this. We're even listing it in the "Preset
Options" section in the docs. I updated this in the new patch set,
which is attached.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0002-Provide-useful-values-for-postgres-C-with-runtime.patch | application/octet-stream | 10.4 KB |
| v8-0001-Introduce-huge_pages_required-GUC.patch | application/octet-stream | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Geoffrey Hoffman | 2021-09-08 18:51:37 | Trouble with docker volume for backup/restore |
| Previous Message | Bossart, Nathan | 2021-09-08 17:48:16 | Re: Estimating HugePages Requirements? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-08 18:01:49 | Re: VARDATA_COMPRESSED_GET_COMPRESS_METHOD comment? |
| Previous Message | Bossart, Nathan | 2021-09-08 17:48:16 | Re: Estimating HugePages Requirements? |