Re: [PATCH] GROUP BY ALL

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, David Christensen <david(at)pgguru(dot)net>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
Subject: Re: [PATCH] GROUP BY ALL
Date: 2025-09-28 09:05:04
Message-ID: B2FFB2B2-2FBD-4B1E-90EF-311ABC7A2776@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Sep 28, 2025, at 06:23, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> + /* Iterate over targets, adding acceptable ones to the result list */
> + foreach_ptr(TargetEntry, tle, *targetlist)
> + {
> + /* Ignore junk TLEs */
> + if (tle->resjunk)
> + continue;

Do we want to specifically check “ctid”?

If a user does:

```
select ctid, col1, col2, ... from t group by all;
```

It would be equivalent to no group by. Combing “select ctid” with “group by all” seems totally useless, but when users do such things, we can optimize that.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-09-28 09:23:51 Re: allow benign typedef redefinitions (C11)
Previous Message jian he 2025-09-28 09:03:58 Re: Why cannot alter column type when a view depends on it?