Re: allow benign typedef redefinitions (C11)

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: "Peter Eisentraut" <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: allow benign typedef redefinitions (C11)
Date: 2025-09-28 09:23:51
Message-ID: a08ed217-1bf3-4c1d-97ca-7f5ca93e53cf@app.fastmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

Here's another simple piece that I noticed while fooling around with the doxygen report -- genam.h was including tidbitmap.h and relcache.h for the sake of one typedefs each, and this was bleeding in other places in a rather random fashion, particularly through amapi.h. I propose the following to fix it. The changes to inet.h and varbit.h are surprising, but required. (It's possible that we should be including varatt.h in more datatype headers than just those two, but at least these are the ones that complained. So another option would be to include varatt.h in the files that include those headers. However, that seems to me to be the wrong direction).

--
Álvaro Herrera

Attachment Content-Type Size
0001-Remove-genam.h-s-dependency-on-relcache.h-and-tidbit.patch text/x-patch 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2025-09-28 09:24:26 Re: Changing shared_buffers without restart
Previous Message Chao Li 2025-09-28 09:05:04 Re: [PATCH] GROUP BY ALL