Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.
Date: 2010-12-17 16:13:51
Message-ID: AANLkTinV+-UX1u6GYrSa3-gxDMUmP4fHdQsKFD9eRpo2@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Dec 17, 2010 at 9:52 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>> Reset 'ps' display just once when resolving VXID conflicts.
>> This prevents the word "waiting" from briefly disappearing from the ps
>> status line when ResolveRecoveryConflictWithVirtualXIDs begins a new
>> iteration of the outer loop.
>
> I imagine the reason for the original coding was to avoid a useless
> gettimeofday kernel call in the common case that there are no
> conflicting xacts to wait for.  Could we restore that behavior?

Something like the attached?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
resolve-recovery-conflict-tweak.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-12-17 16:20:27 Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.
Previous Message Tom Lane 2010-12-17 14:52:04 Re: pgsql: Reset 'ps' display just once when resolving VXID conflicts.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-12-17 16:18:35 Re: bug in SignalSomeChildren
Previous Message Tom Lane 2010-12-17 16:12:17 Re: bug in SignalSomeChildren