Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.
Date: 2010-12-17 16:20:27
Message-ID: 752.1292602827@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Dec 17, 2010 at 9:52 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I imagine the reason for the original coding was to avoid a useless
>> gettimeofday kernel call in the common case that there are no
>> conflicting xacts to wait for. Could we restore that behavior?

> Something like the attached?

I would just add the return-at-the-top. Changing the loop logic is
not necessary --- the loop test is cheap.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-12-17 16:33:02 pgsql: Try to save a kernel call in ResolveRecoveryConflictWithVirtualX
Previous Message Robert Haas 2010-12-17 16:13:51 Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-12-17 16:21:57 Re: proposal: FOREACH-IN-ARRAY (probably for 9.2?)
Previous Message Tom Lane 2010-12-17 16:18:35 Re: bug in SignalSomeChildren