Re: pgsql: Reset 'ps' display just once when resolving VXID conflicts.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Reset 'ps' display just once when resolving VXID conflicts.
Date: 2010-12-17 14:52:04
Message-ID: 29167.1292597524@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Reset 'ps' display just once when resolving VXID conflicts.
> This prevents the word "waiting" from briefly disappearing from the ps
> status line when ResolveRecoveryConflictWithVirtualXIDs begins a new
> iteration of the outer loop.

I imagine the reason for the original coding was to avoid a useless
gettimeofday kernel call in the common case that there are no
conflicting xacts to wait for. Could we restore that behavior?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-12-17 16:13:51 Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.
Previous Message Robert Haas 2010-12-17 13:34:32 pgsql: Reset 'ps' display just once when resolving VXID conflicts.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-12-17 15:13:54 Re: patch: remove redundant code from pl_exec.c
Previous Message Andrew Dunstan 2010-12-17 14:45:56 Re: clang and LLVM