From: | Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Debug works, Release not |
Date: | 2011-01-06 19:30:28 |
Message-ID: | AANLkTimYsu7eaBj222onjTg53_XZ0cEiq+FKM9AniXY5@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
here is the patch, that enables UI for pgAgent 4.
It would be great if somebody could try to build in Release mode.
The UI should work with pgAgent schema version 3 - if not, please tell me.
Please tell me also, if I have violated coding policies or something else.
To test the new features, you can apply attached pgagent_upgrade.sql.
Thanks & Regards,
Jasmin
2011/1/5 Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com>
> This could be an issue, but the problem occurs at the pointer to the
> combobox. If I debug it (in Release) I'm getting the exception when trying
> to step in AppendItem-Method. Step-In into GetVal works.
> I will provide a patch asap, so someone of you guys can try to build it.
> Maybe it's because of my environment.
>
> Regards
>
> 2011/1/5 Magnus Hagander <magnus(at)hagander(dot)net>
>
> Not sure if I've seen it with pgadmin, but could it be that the debug
>> build initializes memory to zero whereas the release build may leave
>> it at random, which means it could be a simple
>> string-with-no-terminating-NULL thing?
>>
>> //Magnus
>>
>> On Wed, Jan 5, 2011 at 12:23, Jasmin Dizdarevic
>> <jasmin(dot)dizdarevic(at)gmail(dot)com> wrote:
>> > Yes, I have. Maybe the problem is VS 2010, however it's very strange.
>> >
>> > 2011/1/5 Dave Page <dpage(at)pgadmin(dot)org>
>> >>
>> >> On Wed, Jan 5, 2011 at 11:09 AM, Jasmin Dizdarevic
>> >> <jasmin(dot)dizdarevic(at)gmail(dot)com> wrote:
>> >> > Hi,
>> >> > have you ever had the problem, that a Debug build works on windows
>> and
>> >> > the
>> >> > Release does not?
>> >> > The problem is an access violation during appending items to a
>> combobox.
>> >> > I tried to disable optimization, without success.
>> >> > It's difficult to provide a patch now, because the changes are not
>> >> > small.
>> >> > Here is the problem line. I've also tried to remove
>> >> > "if(connection->pgAgentMinimumVersion(4))".
>> >> > I've included the upper section (pga_jobclass) to demonstrate the
>> >> > similarity
>> >> > of the code - this works well!
>> >> > I've added the cbEmailNotType-Combobox to the xrc file and also a
>> >> > pointer to
>> >> > it. Have I forgotten something important, that is required for
>> >> > a successful release?
>> >>
>> >> I don't see any obvious issues, but have you tried a complete clean
>> >> and rebuild? That can solve a host of weird problems...
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Magnus Hagander
>> Me: http://www.hagander.net/
>> Work: http://www.redpill-linpro.com/
>>
>
>
Attachment | Content-Type | Size |
---|---|---|
pgagent_upgrade.sql | application/octet-stream | 2.0 KB |
0001-UI-Changes-for-pgAgent-4.-Email-notification-and-SQL.patch | application/octet-stream | 18.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jasmin Dizdarevic | 2011-01-06 22:38:26 | Re: Support for unlogged tables |
Previous Message | Dave Page | 2011-01-06 18:24:48 | Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers |