Re: Support for unlogged tables

Hi,

I've just build the latest master branch.
I think there is a problem with the unlogged feature. pgAdmin crashes on
pgsql 8.4. The problem (access violation) occurs on line 1224:

*if (chkUnlogged->GetValue())*
sql += wxT("UNLOGGED ")

Regards,
Jasmin

2011/1/1 Guillaume Lelarge <guillaume(at)lelarge(dot)info>

> Le 31/12/2010 15:27, Magnus Hagander a écrit :
> > On Fri, Dec 31, 2010 at 15:07, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> wrote:
> >> Le 31/12/2010 12:43, Magnus Hagander a écrit :
> >>> On Fri, Dec 31, 2010 at 00:28, Guillaume Lelarge <
> guillaume(at)lelarge(dot)info> wrote:
> >>>> Hi,
> >>>>
> >>>> This 9.1 new feature is supported with this patch. It takes care of
> the
> >>>> table property tab, table dialog, and pg_dump window.
> >>>>
> >>>> Comments?
> >>>
> >>> Haven't tried building it, but this looks weird:
> >>>
> >>> - EVT_CHECKBOX(XRCID("chkHasOids"),
> dlgProperty::OnChange)
> >>> + EVT_CHECKBOX(XRCID("chkUnlogged"),
> dlgProperty::OnChange)
> >>>
> >>>
> >>> should it really move the HasOids one?
> >>>
> >>>
> >>
> >> Yes. I don't know why but we had two lines with chkHasOids, that both
> >> called dlgProperty::OnChange when there is an event on the checkbox.
> >
> > Oh. Interesting. :S
> >
>
> Commited. I know that was a bit quick, but this was an easy one and I
> wanted a good start for this new year. I hope this will be good omens :)
>
>
> --
> Guillaume
> http://www.postgresql.fr
> http://dalibo.com
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>