Re: Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Mark Llewellyn <mark_llewellyn(at)adp(dot)com>, pgsql-hackers(at)postgresql(dot)org, Sujeet Rajguru <sujeet(dot)rajguru(at)enterprisedb(dot)com>
Subject: Re: Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running
Date: 2010-09-24 14:15:08
Message-ID: AANLkTimFTNqkPUsUhfWqHtThpu6iJ6OYH1etFYXa1tM8@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Sep 24, 2010 at 16:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> I took a quick look at the code, and from what I can tell this is
>> because PQconnectionNeedsPassword() always returns false if a
>> pgpass.conf has been used. There is no handling the case where pgpass
>> is used, but has an incorrect password.
>
> Why should it?  That code is complicated enough, I don't think it needs
> to have a behavior of pretending that a wrong entry isn't there.

In that case, we should probably teach pg_ctl about this case, no?
Since it clearly gives an incorrect message to the user now...

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andreas Pflug 2010-09-24 14:37:17 Re: BUG #5675: out of memory at request size 32Mb
Previous Message Tom Lane 2010-09-24 14:04:55 Re: Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-09-24 14:15:53 Re: Configuring synchronous replication
Previous Message Simon Riggs 2010-09-24 14:13:13 Re: Configuring synchronous replication