From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Takahiro Itagaki <itagaki(dot)takahiro(at)gmail(dot)com> |
Subject: | Re: updated patch for foreach stmt |
Date: | 2011-02-08 20:32:12 |
Message-ID: | AANLkTik1bzO9wRyB46jQZbBQNNDm=5J=Wxh=LhRsSi8A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Feb 8, 2011 at 3:26 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Greetings,
>
> * Pavel Stehule (pavel(dot)stehule(at)gmail(dot)com) wrote:
>> I resend a patch with last update of this patch
>
> Alright, so, like I said, I really like this feature and would like to
> see it included. To that end, I've done perhaps a bit more than a
> review of the patch. Pavel, if you could go over the changes I've made
> and review them and let me know if you see any problems, I'd appreciate
> it. I've tried to get it ready for a committer as much as I can without
> being one. :)
Amen to that!
I think the syntax Tom suggested before was FOREACH thingy IN ARRAY
arr rather than just FOREACH thingy IN arr. That's probably a good
idea, because it gives us an escape hatch against needing to invent
yet another variant of this syntax - the word immediately following IN
can be known with confidence to be intended as a keyword rather than
as part of the expression.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2011-02-08 20:35:06 | Re: Extensions support for pg_dump, patch v27 |
Previous Message | Stephen Frost | 2011-02-08 20:26:24 | Re: updated patch for foreach stmt |