| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Takahiro Itagaki <itagaki(dot)takahiro(at)gmail(dot)com> |
| Subject: | Re: updated patch for foreach stmt |
| Date: | 2011-02-08 21:00:05 |
| Message-ID: | 20110208210005.GR4116@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> Amen to that!
Hopefully it helped. :)
> I think the syntax Tom suggested before was FOREACH thingy IN ARRAY
> arr rather than just FOREACH thingy IN arr. That's probably a good
> idea, because it gives us an escape hatch against needing to invent
> yet another variant of this syntax - the word immediately following IN
> can be known with confidence to be intended as a keyword rather than
> as part of the expression.
Alright, alright, *I* don't care that much, though I do feel it's a bit
excessive. Updated patch against HEAD attached.
commit a5d32fa41fbbbd9ace465f62be714366990061d4
Author: Stephen Frost <sfrost(at)snowman(dot)net>
Date: Tue Feb 8 15:57:40 2011 -0500
PL/PgSQL FOREACH - Add ARRAY keyword
Add ARRAY as required after IN when using FOREACH, to
future-proof against later kinds of FOREACH commands.
Thanks,
Stephen
| Attachment | Content-Type | Size |
|---|---|---|
| plpgsql_foreach_2011020802.patch | text/x-diff | 38.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2011-02-08 21:04:51 | Re: updated patch for foreach stmt |
| Previous Message | Pavel Stehule | 2011-02-08 20:55:53 | Re: updated patch for foreach stmt |