Re: Gotchas about pg_verify_checksums

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: Gotchas about pg_verify_checksums
Date: 2018-04-15 07:49:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 15 Apr 2018, at 09:36, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Apr 10, 2018 at 10:27:19PM +0200, Daniel Gustafsson wrote:
>> Thinking more on this, I don’t think the -f option should be in the tool until
>> we have the ability to turn on/off checksums. Since checksums are always on,
>> or always off, -f is at best confusing IMO. The attached patch removes -f,
>> when we can turn checksums on/off we can rethink how -f should behave.
> You have forgotten to update the list of arguments in getopt().

Doh. Thanks, fixed in attached patch.

cheers ./daniel

Attachment Content-Type Size
remove_force-v2.patch application/octet-stream 2.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2018-04-15 09:08:27 Re: pgsql: Revert "Allow on-line enabling and disabling of data checksums"
Previous Message Michael Paquier 2018-04-15 07:36:01 Re: Gotchas about pg_verify_checksums