From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Gotchas about pg_verify_checksums |
Date: | 2018-04-15 11:54:13 |
Message-ID: | CABUevEypFu4qisSwQ=xGiTKMvB28yRd+84n1sdZubjQ_s9ktTA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Apr 15, 2018 at 9:49 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 15 Apr 2018, at 09:36, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Tue, Apr 10, 2018 at 10:27:19PM +0200, Daniel Gustafsson wrote:
> >> Thinking more on this, I don’t think the -f option should be in the
> tool until
> >> we have the ability to turn on/off checksums. Since checksums are
> always on,
> >> or always off, -f is at best confusing IMO. The attached patch removes
> -f,
> >> when we can turn checksums on/off we can rethink how -f should behave.
> >
> > You have forgotten to update the list of arguments in getopt().
>
> Doh. Thanks, fixed in attached patch.
>
I have applied this patch along with the documentation patch from Michael.
Thanks!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2018-04-15 11:57:52 | Re: pgsql: Revert "Allow on-line enabling and disabling of data checksums" |
Previous Message | Christoph Berg | 2018-04-15 09:08:27 | Re: pgsql: Revert "Allow on-line enabling and disabling of data checksums" |