Re: Gotchas about pg_verify_checksums

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: Gotchas about pg_verify_checksums
Date: 2018-04-15 07:36:01
Message-ID: 20180415073601.GA20749@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 10, 2018 at 10:27:19PM +0200, Daniel Gustafsson wrote:
> Thinking more on this, I don’t think the -f option should be in the tool until
> we have the ability to turn on/off checksums. Since checksums are always on,
> or always off, -f is at best confusing IMO. The attached patch removes -f,
> when we can turn checksums on/off we can rethink how -f should behave.

You have forgotten to update the list of arguments in getopt().
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2018-04-15 07:49:33 Re: Gotchas about pg_verify_checksums
Previous Message Sergei Kornilov 2018-04-15 07:09:11 Re: using index or check in ALTER TABLE SET NOT NULL