| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Jacob Champion <pchampion(at)vmware(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz> |
| Subject: | Re: Preventing abort() and exit() calls in libpq |
| Date: | 2021-07-01 18:05:59 |
| Message-ID: | 9d35a4ac-2c75-cb44-95ab-61d69deb072e@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01.07.21 00:41, Jacob Champion wrote:
> On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
>> I wrote:
>>> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>>>> Could we set this rule up a little bit differently so that it is only
>>>> run when the library is built.
>>>> Right now, make world on a built tree makes 17 calls to this "nm" line,
>>>> and make check-world calls it 81 times. I think once would be enough. ;-)
>>> Hmm, didn't realize that would happen. Will see what can be done.
>>
>> Looks like we'd have to make use of a dummy stamp-file, more or less
>> as attached. Any objections?
>
> Spitballing -- if you don't like the stamp file, you could add the
> check to the end of the $(shlib) rule, surrounded by an ifeq check.
> Then .DELETE_ON_ERROR should take care of the rest, I think.
Somewhere in the $(shlib) rule would seem most appropriate. But I don't
understand the rest: What ifeq, and why .DELETE_ON_ERROR?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-01 18:14:24 | Re: Preventing abort() and exit() calls in libpq |
| Previous Message | Jacob Champion | 2021-07-01 17:24:22 | Re: Remove unused code from the KnownAssignedTransactionIdes submodule |