| From: | Jacob Champion <pchampion(at)vmware(dot)com> |
|---|---|
| To: | "peter(dot)eisentraut(at)enterprisedb(dot)com" <peter(dot)eisentraut(at)enterprisedb(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz> |
| Subject: | Re: Preventing abort() and exit() calls in libpq |
| Date: | 2021-06-30 22:41:01 |
| Message-ID: | 67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
> I wrote:
> > Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> > > Could we set this rule up a little bit differently so that it is only
> > > run when the library is built.
> > > Right now, make world on a built tree makes 17 calls to this "nm" line,
> > > and make check-world calls it 81 times. I think once would be enough. ;-)
> > Hmm, didn't realize that would happen. Will see what can be done.
>
> Looks like we'd have to make use of a dummy stamp-file, more or less
> as attached. Any objections?
Spitballing -- if you don't like the stamp file, you could add the
check to the end of the $(shlib) rule, surrounded by an ifeq check.
Then .DELETE_ON_ERROR should take care of the rest, I think.
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-06-30 22:42:31 | Re: Dependency to logging in jsonapi.c |
| Previous Message | Jacob Champion | 2021-06-30 22:30:12 | Re: [PATCH] Pull general SASL framework out of SCRAM |