| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Roman Khapov <rkhapov(at)yandex-team(dot)ru> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-01-14 14:51:06 |
| Message-ID: | SYAPR01MB303853F66A53ED2297560915B68FA@SYAPR01MB3038.ausprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 14 Jan 2026 at 17:44, Roman Khapov <rkhapov(at)yandex-team(dot)ru> wrote:
>> I agree — the NULL handling seems wrong.
>> Here's a quick patch to fix it. What do you think?
>
> LGTM, but maybe the test should be expanded with NULL for the two-column
> indexes? I mean to add NULLs at zero column too.
>
Sorry, I’m not sure I understand.
Are you suggesting we add one (or both) of these test cases?
INSERT INTO test1 VALUES (2, NULL, NULL);
INSERT INTO test1 VALUES (2, ARRAY[NULL, 222], ARRAY['d', NULL]);
> Also, about the tests but not related to NULLs...
> Seems like we need to run those tests on 32bit system, the test output should be different?
>
Agree.
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2026-01-14 14:55:20 | Re: Add IS_INDEX macro to brin and gist index |
| Previous Message | Peter Eisentraut | 2026-01-14 14:36:09 | Re: remove pg_restrict workaround |