Re: Improve prep_buildtree

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve prep_buildtree
Date: 2025-07-30 09:31:58
Message-ID: 9914be83-0ebc-483a-93a1-02201c2e1bda@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 30.07.25 10:28, Nazir Bilal Yavuz wrote:
> On Wed, 30 Jul 2025 at 11:07, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> To fix this, I first tried to devise a way to detect whether a given
>> directory is a build directory. But that seemed pretty complicated.
>> Instead, I chose the simpler solution that we just enumerate the source
>> subdirectories that we know about (config, contrib, doc, src). That way
>> we can also remove the special handling to exclude the .git directory
>> and make the find command a bit simpler.
>
> Meson looks for ${builddir}/meson-private/coredata.dat file to
> understand if the directory is a build directory [1]. I am just
> wondering if you tried this and found it complicated or did you try
> something else.

I tried things along this line, but it's not easy to have a shell "find"
command handle that kind of logic.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2025-07-30 09:35:52 Re: 024_add_drop_pub.pl might fail due to deadlock
Previous Message Jean-Christophe Arnu 2025-07-30 09:14:46 Re: restore_command return code behaviour