Re: Improve prep_buildtree

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve prep_buildtree
Date: 2025-07-30 08:28:57
Message-ID: CAN55FZ3mkr_9qfaduc6ELj7eYvfV-tpt3s-_XE1gQxZj7pm=vg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you for working on this!

On Wed, 30 Jul 2025 at 11:07, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> To fix this, I first tried to devise a way to detect whether a given
> directory is a build directory. But that seemed pretty complicated.
> Instead, I chose the simpler solution that we just enumerate the source
> subdirectories that we know about (config, contrib, doc, src). That way
> we can also remove the special handling to exclude the .git directory
> and make the find command a bit simpler.

Meson looks for ${builddir}/meson-private/coredata.dat file to
understand if the directory is a build directory [1]. I am just
wondering if you tried this and found it complicated or did you try
something else.

[1] https://github.com/mesonbuild/meson/blob/b4d32763940ae67d1ed36952112b3d94ba9f03a7/mesonbuild/mcompile.py#L30C1-L35C82

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2025-07-30 08:29:00 Re: Logical Replication of sequences
Previous Message Álvaro Herrera 2025-07-30 08:23:08 Re: pg_dump --with-* options