Re: Improve prep_buildtree

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve prep_buildtree
Date: 2025-07-30 13:34:58
Message-ID: 1484034.1753882498@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 30.07.25 10:28, Nazir Bilal Yavuz wrote:
>> Meson looks for ${builddir}/meson-private/coredata.dat file to
>> understand if the directory is a build directory [1]. I am just
>> wondering if you tried this and found it complicated or did you try
>> something else.

> I tried things along this line, but it's not easy to have a shell "find"
> command handle that kind of logic.

For this purpose, I think it's better for us to rely on things we
control than things Meson controls. Adding a new top-level directory
is rare enough that I don't see a problem with needing to update
prep_buildtree.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-07-30 15:04:17 Re: pg_dump --with-* options
Previous Message Dagfinn Ilmari Mannsåker 2025-07-30 13:25:38 Re: Support getrandom() for pg_strong_random() source