| From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Amcheck: do rightlink verification with lock coupling |
| Date: | 2020-08-04 16:32:57 |
| Message-ID: | 9737FA95-7D97-49D4-AB5A-911A4EAA7A4D@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 4 авг. 2020 г., в 03:44, Peter Geoghegan <pg(at)bowt(dot)ie> написал(а):
>
> On Mon, Jul 20, 2020 at 11:46 AM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>> In this thread [0] we decided that lock coupling is necessary for btree_xlog_unlink_page().
>> So, maybe let's revive this patch?
>
> Yes, let's do that. Can you resubmit it, please?
PFA v3.
Changes: fixed few typos in comments.
BTW, reviewing this patch again I cannot understand why we verify link coherence only on leaf level but not for internal pages?
I do not see any actual problems here.
Corruption detection power of leftlink-rightlinks on internal pages is diminishingly small compared to leaf pages. But there seems to be no reason to exclude internal pages?
Thanks!
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-In-amcheck-nbtree-do-rightlink-verification-with-.patch | application/octet-stream | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-08-04 16:44:23 | Re: new heapcheck contrib module |
| Previous Message | Tomas Vondra | 2020-08-04 16:21:44 | Re: Parallel copy |