Re: pgsql: Fix compiler warning for ppoll() on Cygwin

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Fix compiler warning for ppoll() on Cygwin
Date: 2019-12-27 03:47:53
Message-ID: CAA8=A7_3HdRzHHDEpW7VjHKgyVD7nR2ZyP-mbgBJT50NAYYRUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Dec 27, 2019 at 10:24 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > On Thu, Dec 26, 2019 at 4:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Next question is why the buildfarm client got that wrong. Seems like
> >> its accache logic needs to notice changes in src/template/* as well as
> >> the configure script proper.
>
> > The problem with that is that a change in one template will cause the cache
> > to be invalidated for every buildfarm member. Maybe that doesn't matter too
> > much - after all we used not to keep the cache at all.
>
> I don't think we change those templates often enough for that to be
> much of a concern. Trying to make the buildfarm script smart enough
> to check only the relevant template seems like more trouble than it'd
> be worth.
>

Right, fix along these lines committed, will be in the next release.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-12-27 09:03:30 pgsql: Forbid DROP SCHEMA on temporary namespaces
Previous Message Tom Lane 2019-12-27 00:07:17 Re: pgsql: Superuser can permit passwordless connections on postgres_fdw