Re: Set statement timeout in the query tool

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Set statement timeout in the query tool
Date: 2009-12-04 17:43:47
Message-ID: 937d27e10912040943t215cf4ccoa66d745bd608b9bc@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Dec 4, 2009 at 5:33 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:

> I see a use case for having both. If someone uses a lot the statement_timeout
> option, he'll be annoyed to put it in the text box every time he launches the
> query tool.

Just save the value in the toolbar using sysSettings.

>> Why save/reset it? The next query will just change it again anyway,
>> and there's no way round that.
>>
>
> Because every other query launch by the query tool will use it. For example
> the one of the GQB (which, AFAIK, uses the same connection).

Right - but you'd still only need to set it once, when the window is
opened, or if the value is changed. There's no need to keep resetting
it.

> I don't have any issues with adding a UI for other parameters (work_mem comes
> to mind immediately). We can put them all in their own toolbar, so that users
> can hide it, so that it doesn't cluter the window UI.

I do. Extra code maintenance and complexity for little gain.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2009-12-04 17:44:29 Re: Set statement timeout in the query tool
Previous Message Guillaume Lelarge 2009-12-04 17:38:02 Re: Set statement timeout in the query tool