| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Fix BRIN to use SnapshotAny during summarization |
| Date: | 2015-08-06 22:40:46 |
| Message-ID: | 928.1438900846@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Fix BRIN to use SnapshotAny during summarization
This patch added an isolation test that fails unless contrib/pageinspect
has been built and installed. I do not find that acceptable. It causes
"make check-world" to fail ... and no, installing the extension during
make check-world isn't going to make me happier.
I don't really think we need this isolation test at all, but if we do,
please fix it to not rely on any extensions. Perhaps looking at
pg_relation_size or some such would do? Or you could just issue
a query that should use the index, and see if it finds the rows it
ought to.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-08-07 00:15:07 | pgsql: Fix eclass_useful_for_merging to give valid results for appendre |
| Previous Message | Bruce Momjian | 2015-08-06 22:03:48 | pgsql: 9.5 release notes: mention change to CRC-32C |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-08-06 22:55:11 | Re: 9.5 release notes |
| Previous Message | Bruce Momjian | 2015-08-06 22:39:27 | Re: 9.5 release notes |