Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)

From: Christoph Berg <myon(at)debian(dot)org>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)
Date: 2015-08-10 11:00:38
Message-ID: 20150810110038.GA20393@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Re: Tom Lane 2015-08-07 <928(dot)1438900846(at)sss(dot)pgh(dot)pa(dot)us>
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Fix BRIN to use SnapshotAny during summarization
>
> This patch added an isolation test that fails unless contrib/pageinspect
> has been built and installed. I do not find that acceptable. It causes
> "make check-world" to fail ... and no, installing the extension during
> make check-world isn't going to make me happier.
>
> I don't really think we need this isolation test at all, but if we do,
> please fix it to not rely on any extensions. Perhaps looking at
> pg_relation_size or some such would do? Or you could just issue
> a query that should use the index, and see if it finds the rows it
> ought to.

Hi,

this breaks the Debian package builds as well because we run
check-world as a build step.

Any chance for a fix/workaround so the nightly master/head builds will
succeed again?

Christoph
--
cb(at)df7cb(dot)de | http://www.df7cb.de/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-08-10 11:29:20 pgsql: Fix copy & paste mistake in pg_get_replication_slots().
Previous Message Tom Lane 2015-08-09 23:01:26 pgsql: Remove gram.y's precedence declaration for OVERLAPS.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-08-10 11:29:21 Re: expose confirmed_flush for replication slots
Previous Message Etsuro Fujita 2015-08-10 10:50:42 Re: Commitfest remaining "Needs Review" items