| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: On Windows, when a file is deleted and another process still has |
| Date: | 2009-09-11 19:21:30 |
| Message-ID: | 9111.1252696890@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Fri, Sep 11, 2009 at 10:44, Heikki Linnakangas
>> Here's a patch implementing that, and changing pgrename() to check for
>> ERROR_SHARING_VIOLATION and ERROR_LOCK_VIOLATION like pgwin32_open()
>> does, instead of ERROR_ACCESS_DENIED.
> I have definitely seen AV programs return access deniderather than
> sharing violation more than once for temporary errors. How about we
> keep the access denied one as well?
+1 ... presumably the original coding was tested in *some* environment.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-09-12 00:04:59 | pgsql: Fix assertion failure when a SELECT DISTINCT ON expression is |
| Previous Message | Tom Lane | 2009-09-11 19:17:04 | pgsql: Increase the maximum value of extra_float_digits to 3, and have |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-09-11 19:42:55 | Re: drop tablespace error: invalid argument |
| Previous Message | Tom Lane | 2009-09-11 19:08:31 | Re: COPY enhancements |