| From: | Vik Fearing <vik(at)postgresfriends(dot)org> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Damien Clochard <damien(at)dalibo(dot)info> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Generate random dates/times in a specified range |
| Date: | 2025-08-29 14:14:19 |
| Message-ID: | 8c68b003-b781-46aa-9c1e-e9991d8fcfd1@postgresfriends.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29/08/2025 11:12, Chao Li wrote:
>
>
>> On Aug 26, 2025, at 22:17, Damien Clochard <damien(at)dalibo(dot)info> wrote:
>>
>> Le 25.08.2025 15:33, Greg Sabino Mullane a écrit :
>>> Your v3 did not get attached to the previous email.
>>
>> My bad, here it is
>>
>> --
>> Damien
>> Clochard<v3-0001-Generate-random-dates-times-in-a-specified-range.patch>
>
> Code change looks good to me. Maybe we can make
> check_range_boundaries() “inline” as well.
>
> But a major problem is, I think we should bump CATALOG_VERSION_NO.
> Otherwise, running your code with an existing database, the new
> functions won’t work.
Traditionally, the patch committer bumps the catversion, not the patch
author.
--
Vik Fearing
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-08-29 14:26:41 | Re: Changing the state of data checksums in a running cluster |
| Previous Message | Vik Fearing | 2025-08-29 14:09:17 | Re: Assert single row returning SQL-standard functions |