| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Damien Clochard <damien(at)dalibo(dot)info> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Generate random dates/times in a specified range |
| Date: | 2025-08-29 09:12:52 |
| Message-ID: | 9891196B-46DA-4F97-BF36-DC7586EF49DE@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Aug 26, 2025, at 22:17, Damien Clochard <damien(at)dalibo(dot)info> wrote:
>
> Le 25.08.2025 15:33, Greg Sabino Mullane a écrit :
>> Your v3 did not get attached to the previous email.
>
> My bad, here it is
>
> --
> Damien Clochard<v3-0001-Generate-random-dates-times-in-a-specified-range.patch>
Code change looks good to me. Maybe we can make check_range_boundaries() “inline” as well.
But a major problem is, I think we should bump CATALOG_VERSION_NO. Otherwise, running your code with an existing database, the new functions won’t work.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Tachoires | 2025-08-29 09:17:21 | Re: Qual push down to table AM |
| Previous Message | shveta malik | 2025-08-29 09:07:32 | Re: Improve pg_sync_replication_slots() to wait for primary to advance |