Re: [PATCH] Generate random dates/times in a specified range

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Vik Fearing <vik(at)postgresfriends(dot)org>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Damien Clochard <damien(at)dalibo(dot)info>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Generate random dates/times in a specified range
Date: 2025-08-29 14:57:08
Message-ID: 2161235.1756479428@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Vik Fearing <vik(at)postgresfriends(dot)org> writes:
> On 29/08/2025 11:12, Chao Li wrote:
>> But a major problem is, I think we should bump CATALOG_VERSION_NO.

> Traditionally, the patch committer bumps the catversion, not the patch
> author.

Yeah. If you include a catversion bump in a submitted patch, you can
expect the patch to break repeatedly while it's sitting in the queue,
due to unrelated patches changing catversion. So we prefer to have
the committer add that at the last moment.

If you're worried that the committer might forget that, you can
add a comment about it in the patch's draft commit message.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2025-08-29 15:02:23 Generate pgstat_count_slru*() functions for slru using macros
Previous Message Tom Lane 2025-08-29 14:47:39 Re: headerscheck warnings with late-model gcc