Re: DOC: fixes multiple errors in alter table doc

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Treat <rob(at)xzilla(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DOC: fixes multiple errors in alter table doc
Date: 2026-03-03 02:09:11
Message-ID: 8F0F27C6-2267-4382-B4B7-C526B2950175@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mar 2, 2026, at 17:22, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
>> On Mar 2, 2026, at 17:04, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>> On Thu, Jan 22, 2026 at 6:38 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>> PFA v3: Rebased, and added reviewer and discussion information.
>>
>> LGTM.
>>
>> Should we apply the same change to the ALTER FOREIGN TABLE docs as well?
>
> Sure, I can make the change.
>
>>
>> While reviewing that section, I noticed that ADD COLUMN IF NOT EXISTS appears
>> to work for ALTER FOREIGN TABLE, but it isn't documented. I'm not sure why
>> it was left out, but perhaps we should document it and add a regression test in
>> a separate patch?
>>
>
> I will verify that, then update the doc and regression test accordingly.
>
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>

PFA v4:

0001 - alter table related changes

* Add test cases for omitting COLUMN of ALTER TABLE ADD/DROP [COLUMN]
* Add a test case for ADD COLUMN IF NOT EXIST (already had DROP COLUMN IF EXIST)

0002 - alter foreign table related changes

* doc: Add IF NOT EXSTS for ADD COLUMN
* doc: Mark COLUMN as optional for ADD/DROP COLUMN in the same way as 0001
* Add test cases for omitting COLUMN of ALTER FOREIGN TABLE ADD/DROP [COLUMN]
* Add a test cases for for ADD COLUMN IF NOT EXIST
* Add a test cases for for DROP COLUMN IF EXIST

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v4-0001-doc-clarify-optional-COLUMN-in-ALTER-TABLE-ADD-DR.patch application/octet-stream 3.6 KB
v4-0002-doc-clarify-ALTER-FOREIGN-TABLE-ADD-DROP-COLUMN-s.patch application/octet-stream 8.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message zhangqiang 2026-03-03 02:38:29 doc: Clarify that empty COMMENT string removes the comment
Previous Message jian he 2026-03-03 01:48:18 Re: pg_dumpall --roles-only interact with other options