Re: pg_dumpall --roles-only interact with other options

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, wangpeng <215722532(at)qq(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dumpall --roles-only interact with other options
Date: 2026-03-03 01:48:18
Message-ID: CACJufxG1f=+WWwKwRD_PMR8YnZkV4HtgDy2YOHrHfcN7sTWXww@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 3, 2026 at 6:41 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> I'm not thrilled about the long list of checks. What if we added a
> function that could check an arbitrary number of mutually exclusive
> options, a bit like the attached?
>
hi.

This is neater than my version, and overall it looks good to me.
Once this is committed, we can use CheckMutuallyExclusiveOpts in both
pg_dump.c and pg_restore.c.

--
jian
https://www.enterprisedb.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-03-03 02:09:11 Re: DOC: fixes multiple errors in alter table doc
Previous Message Andreas Karlsson 2026-03-03 01:22:21 Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()